SPR-8335: fixed default-lazy-init processing when xsd validation is disabled #2071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the xml parser does not fill in defaults provided in the xsd when validation is disabled. As a result, attributes like default-lazy-init will not receive the value "default" but an empty string value. The BeanDefinitionParserDelegate did not take this into account. So, we should also check on an empty string value, which is semantically the same as the value "default". Issues: SPR-8335
|
@MichelSchudel Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@MichelSchudel Thank you for signing the Contributor License Agreement! |
|
I have merged a polished version of your commit, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml parser does not fill in defaults provided in the xsd when validation is disabled.
As a result, attributes like default-lazy-init will not receive the value "default" but an empty
string value. This also applies for other default attributes in the root or parent elements.
The BeanDefinitionParserDelegate did not take this into account. So, we should also check on an empty string value, which is semantically the same as the value "default".
Issues: SPR-8335