Replace signal materialization in TransactionAspectSupport with usingWhen #22911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…When We now use Flux.usingWhen() instead materialize/dematerialize operators to reuse Reactor's resource closure. Until usingWhen() accepts a BiFunction to consume error signals, we need to map error signals outside of usingWhen which requires re-wrapping of the ReactiveTransaction object. Also, reuse the current TransactionContext to leave Transaction creation/propagation entirely to ReactiveTransactionManager instead of creating new TransactionContexts.
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use
Flux.usingWhen()instead materialize/dematerialize operators to reuse Reactor's resource closure.Until
usingWhen()accepts a BiFunction to consume error signals, we need to map error signals outside ofusingWhenwhich requires re-wrapping of the ReactiveTransaction object.Also, reuse the current
TransactionContextto leave Transaction creation/propagation entirely to ReactiveTransactionManager instead of creating new TransactionContexts.