Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing netty-all with specific dependencies #23465

Closed
wants to merge 1 commit into from

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Aug 15, 2019

As per @bclozel 's comment on the below:

Spring Framework is sometimes depending on "-all.jar" variants for historical reasons, and doing so in an application or library is not advised. Arguably we should not do that in our build and this is something we should fix. But in the meantime this is incorrect/misleading information we're publishing

#23234 (comment)

spring-framework/spring-web/src contains references to following netty packages covered by the artifacts:

  • artifact netty-buffer
    • io.netty.buffer
  • artifact netty-transport
    • io.netty.channel
    • io.netty.bootstrap
    • io.netty.channel.nio
  • artifact netty-handler
    • io.netty.handler.ssl
    • io.netty.handler.ssl.util
    • io.netty.handler.timeout
  • artifact netty-codec-http
    • io.netty.handler.codec.http

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 15, 2019
Copy link

@mentallurg mentallurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the idea to use more precise libraries. But have you tested it? How about netty-common? Anything else?

@suztomo
Copy link
Contributor Author

suztomo commented Aug 26, 2019

But have you tested it?

It compiles successfully. I added the list of packages and artifacts relationship. I didn't find netty-common needed.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 8, 2019
@rstoyanchev rstoyanchev self-assigned this Nov 8, 2019
@rstoyanchev rstoyanchev added this to the 5.2.2 milestone Nov 8, 2019
@rstoyanchev
Copy link
Contributor

This has been rebased and merged 21d390a.

@rstoyanchev rstoyanchev closed this Nov 8, 2019
@suztomo
Copy link
Contributor Author

suztomo commented Nov 8, 2019

Thank you.

@suztomo suztomo deleted the netty-dependency branch November 8, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants