Skip to content

Defer creating LogAccessor #23656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Defer creating LogAccessor #23656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion spring-core/src/main/java/org/springframework/core/io/AbstractResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
*/
public abstract class AbstractResource implements Resource {

private static final LogAccessor logAccessor = new LogAccessor(AbstractResource.class);
private static volatile LogAccessor logAccessor;

/**
* This implementation checks whether a File can be opened,
Expand All @@ -65,6 +65,9 @@ public boolean exists() {
return true;
}
catch (Throwable isEx) {
if (logAccessor == null) {
logAccessor = new LogAccessor(AbstractResource.class);
}
logAccessor.debug(ex,
() -> "Could not close InputStream for resource: " + getDescription());
return false;
Expand Down Expand Up @@ -164,6 +167,9 @@ public long contentLength() throws IOException {
is.close();
}
catch (IOException ex) {
if (logAccessor == null) {
logAccessor = new LogAccessor(AbstractResource.class);
}
logAccessor.debug(ex,
() -> "Could not close InputStream for resource: " + getDescription());
}
Expand Down