CaffeineCache with LoadingCache #25194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CaffeineCache is created with a LoadingCache, the LoadingCache is used with the method `public ValueWrapper get(Object key)` but not with method `public <T> T get(Object key, @nullable Class<T> type)`. Using LoadingCache is incompatible with @Cacheable pattern but consistently call the LoadingCache in both methods is better than now. Removing the usage is a backward-incompatible change. Closes spring-projectsgh-25173
|
@stefano-salmaso Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@stefano-salmaso Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
@snicoll ... any chance to take this PR into consideration? |
|
It very much was @stefano-salmaso but I've been busy on other things lately. I apologize for the delay and I've flagged the original issue for the |
|
Thanks for the PR but I've decided to use a different approach, see f3cedf2 for more details. |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CaffeineCache is created with a LoadingCache, the LoadingCache is
used with the method
public ValueWrapper get(Object key)but notwith method
public <T> T get(Object key, @Nullable Class<T> type).Using LoadingCache is incompatible with @Cacheable pattern but
consistently call the LoadingCache in both methods is better than now.
Removing the usage is a backward-incompatible change.
Closes gh-25173