Align DispatcherServlet defaults for Java and XML #25260
Closed
+164
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit some of the default strategies defined for the DispatcherServlet weren't included in the default configuration for both Java and XML configuration. The following default beans have been added to the configuration with the name as expected by the DispatcherServlet: . org.springframework.web.servlet.i18n.AcceptHeaderLocaleResolver . org.springframework.web.servlet.theme.FixedThemeResolver . org.springframework.web.servlet.support.SessionFlashMapManager . org.springframework.web.servlet.view.DefaultRequestToViewNameTranslator Fixes: spring-projectsgh-25209
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
removed
the
status: waiting-for-triage
spring-projects-issues
added
the
status: waiting-for-triage
|
Merged via bad81ce, thanks for your contribution, much appreciated. |
rstoyanchev
added
in: web
|
This can impact existing applications, on the Java config side in particular, that already define those beans in order to customize them or to choose the implementation. One of them at least is defined in Spring Boot. As far as I can see this will suppress use of the |
|
Indeed this is tracked by #25290, I am working on a fix. |
|
Okay, I missed that. I guess I'll close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit some of the default strategies defined
for the DispatcherServlet weren't included in the default
configuration for both Java and XML configuration.
The following default beans have been added to the configuration
with the name as expected by the DispatcherServlet:
Fixes: gh-25209