Support cookies with Expires attribute but no Max-Age attribute in MockHttpServletResponse #26558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koosg Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@koosg Thank you for signing the Contributor License Agreement! |
sbrannen
added
in: test
sbrannen
changed the title
|
For reference: HTTP Cookie Syntax. |
sbrannen
changed the title
sbrannen
added
type: enhancement
spring-projects-issues
added
status: backported
sbrannen
added a commit
that referenced
this pull request
Feb 17, 2021
sbrannen
added a commit
that referenced
this pull request
Feb 17, 2021
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 17, 2021
Prior to this commit, MockHttpServletResponse only included the Expires attribute in the generated Cookie header if the Max-Age attribute had also been set. This commit supports including the Expires attribute in the generated Cookie Header even when the Max-Age attribute has not been set. Closes spring-projectsgh-26558
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 17, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 17, 2021
|
This has been merged into Thanks |
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Prior to this commit, MockHttpServletResponse only included the Expires attribute in the generated Cookie header if the Max-Age attribute had also been set. This commit supports including the Expires attribute in the generated Cookie Header even when the Max-Age attribute has not been set. Closes spring-projectsgh-26558
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec it is allowed to have cookies that only use the
Expiresattribute (even though it's really old style).MockHttpServletResponsedidn't previously support that properly.So, added a testcase and made it work.