Local @CrossOrigin maxAge value should override global value #26619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
in: web
|
The Javadoc for
In light of that, I have labeled this as a bug to be fixed in 5.3.5 and backported to 5.2.14. Good catch! |
sbrannen
changed the title
spring-projects-issues
added
status: backported
sbrannen
added a commit
that referenced
this pull request
Mar 2, 2021
sbrannen
pushed a commit
that referenced
this pull request
Mar 2, 2021
Prior to this commit, a method-level @crossorigin maxAge value did not override a class-level @crossorigin maxAge value. This contradicts the Javadoc for @Crossorgin which states the following. For those attributes where only a single value can be accepted such as allowCredentials and maxAge, the local overrides the global value. This commit ensures that a method-level @crossorigin maxAge value overrides a class-level @crossorigin maxAge value. Closes gh-26619
sbrannen
added a commit
that referenced
this pull request
Mar 2, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Prior to this commit, a method-level @crossorigin maxAge value did not override a class-level @crossorigin maxAge value. This contradicts the Javadoc for @Crossorgin which states the following. For those attributes where only a single value can be accepted such as allowCredentials and maxAge, the local overrides the global value. This commit ensures that a method-level @crossorigin maxAge value overrides a class-level @crossorigin maxAge value. Closes spring-projectsgh-26619
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute of CrossOrigin that be applied to method will override that be applied to class, like origins, but maxAge is different，so I think we would modify it