Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusAssertion value methods fail when used with custom status code #26658

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

MichalStehlikCz
Copy link
Contributor

StatusAssertion value methods used for status assertions with custom matchers fail when returned status code is not one of states recognized by Spring Framework. Problem is that HttpStatus is retrieved and then converted back to integer instead of retrieving raw status directly.

Change will make behaviour consistent with isEqualTo method.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 10, 2021
@jhoeller jhoeller self-assigned this Mar 11, 2021
@jhoeller jhoeller added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 11, 2021
@jhoeller jhoeller added this to the 5.3.5 milestone Mar 11, 2021
@jhoeller jhoeller merged commit 79b5710 into spring-projects:master Mar 11, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x labels Mar 11, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants