fix:Spring fails to determine XML is XSD-based if DOCTYPE appears in a comment #27927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix:Spring fails to determine XML is XSD-based if DOCTYPE appears in a comment
|
@shooye Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@shooye Thank you for signing the Contributor License Agreement! |
sbrannen
added
in: core
Thank Sam Brannen give me advice: > I noticed that you introduced a second boolean flag to track whether we're "in a comment", and I thought we would still only need a single flag for that. I have removed the second Boolean flag, Use only a Boolean said to track whether we're "in a comment". Also, this method also passed all tests.
|
Hi @shooye, We really appreciate all the effort you put in to provide a fix! In the end, we decided to go with a simpler solution that relies on recursion in order to reuse the existing comment parsing logic. If you're interested in checking it out, you'll find it in 4b1b254#diff-d2b71d5dbef74357add917ba7662a8f3d376fe9e965f82cd08407587b55bf833. In light of that, I am closing this PR. Thanks again for reporting this set of bugs. |
sbrannen
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It solves the problem that
XmlValidationModeDetectorcannot determine whether XML is based on XSD due to improper parsing of comments spanning multiple lines in the original XML configuration file.Fixes #27915