Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Locale to SpringValidator for validation message interpolator in Spring WebFlux #28739

Closed
wants to merge 3 commits into from

Conversation

borisfox73
Copy link
Contributor

Temporarily set LocaleContextHolder to provide validation message interpolator with locale context (SPR-17231).
Fixes #21764.

…erpolator with locale context (fixes SPR-17231).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 1, 2022
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jul 1, 2022
@sbrannen sbrannen requested a review from rstoyanchev July 1, 2022 08:28
@rstoyanchev rstoyanchev self-assigned this Jan 27, 2023
@rstoyanchev rstoyanchev removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 27, 2023
@rstoyanchev rstoyanchev added this to the 6.0.5 milestone Jan 27, 2023
@rstoyanchev rstoyanchev changed the title Spring WebFlux - Provide LocaleContext for validation message interpolator Expose Locale to SpringValidator for validation message interpolator in Spring WebFlux Jan 27, 2023
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I will set it for 6.1 since it is a change of behavior and can impact applications.

@rstoyanchev rstoyanchev modified the milestones: 6.0.5, 6.1.0-M1 Feb 13, 2023
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jun 13, 2023

Looks like this change made it into 6.0.5 already with 72926c2 despite my comment above to the contrary. I'll close the pull request, and mark it accordingly.

@rstoyanchev rstoyanchev modified the milestones: 6.1.0-M1, 6.0.5 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring WebFlux - Custom messages validation in different languages [SPR-17231]
4 participants