Skip to content

Fix typos in test code #28807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typos in test code #28807

wants to merge 1 commit into from

Conversation

@marcwrobel
Copy link
Contributor

@marcwrobel marcwrobel commented Jul 12, 2022

Fixes typos in test class names, test method names and test variable names.

@marcwrobel
Fix typos in test code
d15c3a6 
Fixes typos in test class names, test method names and test variable names.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 12, 2022
@sbrannen sbrannen self-assigned this Jul 13, 2022
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 13, 2022
@sbrannen sbrannen added this to the 5.3.22 milestone Jul 13, 2022
sbrannen
sbrannen reviewed Jul 13, 2022
View reviewed changes
...springframework/test/context/junit/jupiter/AutowiredConfigurationErrorsIntegrationTests.java
AutowiredParameterizedTestMethod.class
})
void autowiredTestMethodsTestTemplateMethodsAndLifecyleMethods(Class<?> testClass) {
void AutowiredTestMethodsTestTemplateMethodsAndLifecycleMethods(Class<?> testClass) {
Copy link
Member

@sbrannen sbrannen Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: we never capitalize the first character in a method name.

So I'll revert these changes when merging.

@sbrannen sbrannen closed this in bd34996 Jul 13, 2022
@sbrannen
Copy link
Member

sbrannen commented Jul 13, 2022

This has been merged into 5.3.x and main.

Thanks for all of your effort recently in cleaning up typos! 👍

@marcwrobel marcwrobel deleted the fix-typos-tests branch July 14, 2022 08:46
@marcwrobel
Copy link
Contributor Author

marcwrobel commented Jul 14, 2022

You are welcome, it was the opportunity to contribute a little bit to this project I used for so many years.

Only a few more PR (#28819, #28821, #28822) and it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrannen sbrannen sbrannen left review comments

Assignees

@sbrannen sbrannen

Labels

type: task A general task

Projects

None yet

Milestone

5.3.22

Development

Successfully merging this pull request may close these issues.

3 participants

@marcwrobel @sbrannen @spring-projects-issues