Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReloadableResourceBundleMessageSource Resource selection hook #30369

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add ReloadableResourceBundleMessageSource Resource selection hook #30369

merged 1 commit into from
Apr 24, 2023

Conversation

simonbasle
Copy link
Contributor

@simonbasle simonbasle commented Apr 24, 2023 •
edited
Loading

This commit enables sub-classes to better customize resource selection
and resource loading in ReloadableResourceBundleMessageSource, without
a need to duplicate the caching logic of refreshProperties.

See gh-30334
Closes gh-30369

@simonbasle
Add ReloadableResourceBundleMessageSource Resource selection hook
3708fb9 
This commit adds support for customization of resource selection and
resource loading in `ReloadableResourceBundleMessageSource`, without
a need to duplicate the caching logic of `refreshProperties`.

Closes spring-projectsgh-30334
@simonbasle simonbasle added this to the 6.1.0-M1 milestone Apr 24, 2023
@simonbasle simonbasle added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Apr 24, 2023
@simonbasle simonbasle self-assigned this Apr 24, 2023
@simonbasle simonbasle requested a review from snicoll April 24, 2023 14:31
snicoll
snicoll approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snicoll snicoll mentioned this pull request Apr 24, 2023
Closed
@simonbasle simonbasle merged commit e63d899 into spring-projects:main Apr 24, 2023
@simonbasle simonbasle deleted the 30334-reloadableResourceMoreExtensions branch April 24, 2023 15:57
sbrannen added a commit that referenced this pull request Apr 25, 2023
@sbrannen
Polish Javadoc in ReloadableResourceBundleMessageSource
2537c7c 
See gh-30369
sbrannen added a commit that referenced this pull request Apr 25, 2023
@sbrannen
Reorganize methods in ReloadableResourceBundleMessageSource
dfe320f 
See gh-30369
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Apr 25, 2023
@sbrannen
Rename determineResource() to resolveResource()
982a094 
See spring-projectsgh-30369
jhoeller added a commit that referenced this pull request Jan 22, 2024
@jhoeller
Avoid double exists() call for common resource resolution
6bd7f02 
See gh-30369
See gh-18990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@simonbasle simonbasle

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@simonbasle @snicoll