Conditions on overloaded beans not honored #31080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I confirm this PR fixes #30688 |
|
Related to #31073 |
|
Thanks for the PR but we've declined this use case, see #30688 (comment) |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the issue #30688 the conditions on the overloaded beans aren't honored in all cases.
This is due to the fact that the
ConfigurationClassBeanDefinitionReaderclass bases its logic about which bean method should be skipped on the method name only. The solution provides a brand-new methodString getMethodSignature();in theMethodMetadataclass, based on which will be decided if a bean should be skipped.