Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to DefaultClientRequestObservationConvention #31125

Conversation

annabuyevich
Copy link

Adding tests to increase coverage and test expected behavior for DefaultClientRequestObservationConvention
class. I would love to contribute more if possible.

Added the following test:

  1. Response with 400 status
  2. Response with unknown status code
  3. Null Request
  4. Null Response
  5. Error in Context

@pivotal-cla
Copy link

@annabuyevich Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@annabuyevich Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 28, 2023
@bclozel bclozel self-assigned this Aug 28, 2023
@bclozel bclozel added type: task A general task theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 28, 2023
@bclozel bclozel closed this in 376a898 Aug 29, 2023
@bclozel bclozel added this to the 6.1.0-RC1 milestone Aug 29, 2023
@bclozel
Copy link
Member

bclozel commented Aug 29, 2023

Thanks @annabuyevich !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: observability An issue related to observability and tracing type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants