Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty resource description in DeprecatedBeanWarner's log message #32647

Closed
wants to merge 1 commit into from

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 16, 2024

In this context, the hasText() method seems more appropriate. This is because considering cases where the resourceDescription string contains only whitespace ensures clearer logging, as it accounts for scenarios where the string is not empty but consists solely of whitespace characters.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 16, 2024
@sbrannen sbrannen self-assigned this Apr 16, 2024
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 16, 2024
@sbrannen sbrannen changed the title Fix: Deprecated bean logging method to check for empty resource descriptions Omit empty resource description in DeprecatedBeanWarner's log message Apr 16, 2024
@sbrannen sbrannen added this to the 6.2.0-M2 milestone Apr 16, 2024
@sbrannen sbrannen closed this in 0d4ef4e Apr 16, 2024
sbrannen added a commit that referenced this pull request Apr 16, 2024
@sbrannen
Copy link
Member

This has been merged into main.

Thanks

@dukbong
Copy link
Contributor Author

dukbong commented Apr 16, 2024

This has been merged into main.

Thanks

Thanks! @sbrannen

@dukbong dukbong deleted the Flow branch April 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants