Refactor: Replace hardcoded path separator with PATH_SEPARATOR constant #33646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the hardcoded '/' path separator with the `PATH_SEPARATOR` constant to improve code readability and maintainability. This change ensures consistency across the codebase when handling path separators.
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
addResourcePathToPackagePathmethod by replacing the hardcoded path separator"/"with thePATH_SEPARATORconstant. The change enhances code maintainability and readability by avoiding magic literals.Key Changes
PATH_SEPARATORconstant in place of the hardcoded'/'.Why this change is necessary
Using constants improves the consistency of the codebase and makes future modifications easier. If the path separator ever needs to change (e.g., for cross-platform support), we can modify the constant in one place without affecting multiple lines of code.
Impact
Please review and provide feedback!