Fix CORS throwing 500 upon encountering a malformed URL #33682 #33688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -38,19 +39,22 @@ public abstract class CorsUtils { | |||
| * Returns {@code true} if the request is a valid CORS one by checking {@code Origin} | |||
| * header presence and ensuring that origins are different. | |||
| */ | |||
| public static boolean isCorsRequest(HttpServletRequest request) { | |||
| public static IsCorsRequestResult isCorsRequest(HttpServletRequest request) { | |||
There was a problem hiding this comment.
Is it OK to introduce a breaking public API change for this bugfix? If so, it's probably worth documenting in the release notes.
spring-web/src/main/java/org/springframework/web/cors/CorsUtils.java
Outdated
Show resolved
Hide resolved
spring-web/src/main/java/org/springframework/web/cors/DefaultCorsProcessor.java
Show resolved
Hide resolved
|
Thanks for the PR @IgorOffline, although I was already working on it (as indicated by the fact that I'm assigned the issue). Your solution is going a bit too far anyway. Note I have mistakenly referred the PR in my own version of the fix though 😅 See gh-33682 |
simonbasle
added
status: declined
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for 33682
Also remove BeforeEach in CrossOriginTests because many tests do not need the "setup" step.