Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TestObservationRegistryAssert.assertThat() with Assertions.assertThat() #33929

Closed
wants to merge 1 commit into from
Closed

Replace TestObservationRegistryAssert.assertThat() with Assertions.assertThat() #33929

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 21, 2024

This PR replaces TestObservationRegistryAssert.assertThat() with Assertions.assertThat().

See micrometer-metrics/micrometer#5551

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 21, 2024
@bclozel bclozel self-assigned this Nov 21, 2024
@sbrannen sbrannen added the type: task A general task label Nov 21, 2024
@bclozel bclozel added theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 21, 2024
@bclozel bclozel added this to the 6.2.1 milestone Nov 21, 2024
@bclozel bclozel closed this in 1910d32 Nov 21, 2024
@bclozel
Copy link
Member

bclozel commented Nov 21, 2024

Thanks @izeye !

@izeye izeye deleted the assert branch November 21, 2024 13:43
@ngocnhan-tran1996 ngocnhan-tran1996 mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bclozel bclozel

Labels
theme: observability An issue related to observability and tracing type: task A general task
Projects
None yet
Milestone
6.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@izeye @bclozel @sbrannen @spring-projects-issues