Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit variable resolution in JSP EvalTag #33945

Closed
wants to merge 1 commit into from
Closed

Fix implicit variable resolution in JSP EvalTag #33945

wants to merge 1 commit into from

Conversation

micopiira
Copy link
Contributor

@micopiira micopiira commented Nov 22, 2024 •
edited by sbrannen
Loading

Overview

The order of parameters passed to ELResolver#getValue was incorrect.

The name should correspond to the property parameter of the getValue method instead base.

Related Issues

@micopiira
Fix EvalTag#resolveImplicitVariable not working
aab53b0 
The order of parameters passde to ELResolver#getValue
was incorrect. The name should correspond to the 'property'
parameter of the getValue method instead 'base'
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 22, 2024
@sbrannen sbrannen self-assigned this Dec 14, 2024
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 14, 2024
@sbrannen sbrannen added this to the 6.2.2 milestone Dec 14, 2024
@sbrannen sbrannen mentioned this pull request Dec 14, 2024
Closed
@sbrannen sbrannen changed the title Fix EvalTag#resolveImplicitVariable not working Fix implicit variable resolution in EvalTag Dec 14, 2024
@sbrannen sbrannen changed the title Fix implicit variable resolution in EvalTag Fix implicit variable resolution in JSP EvalTag Dec 14, 2024
sbrannen added a commit that referenced this pull request Dec 14, 2024
@sbrannen
Polish contribution
3d0fffa 
See gh-33945
@sbrannen sbrannen closed this in 71f872e Dec 14, 2024
@sbrannen
Copy link
Member

Hi @micopiira,

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into 6.2.x and main in 71f872e and slightly revised in 3d0fffa and a89db89 and will be available in Spring Framework 6.2.2.

For future PRs, please make sure you use BDDMockito.given instead of Mockito.when; otherwise, the build fails due to our Checkstyle rules. Running a local Gradle build should also help to catch that.

Thanks for your contribution!

Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Projects
None yet
Milestone
6.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@micopiira @sbrannen @spring-projects-issues