Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDisposition should match attributes in a case-insensitive fashion #34383

Closed
wants to merge 2 commits into from

Conversation

dobrosi
Copy link
Contributor

@dobrosi dobrosi commented Feb 7, 2025

File name is null bug. HTTP clients may send a file with a "FileName" attribute in the Content-Disposition header.

RFC 6266: 'The parameters "filename" and "filename*", to be matched case-insensitively, provide information on how to construct a filename for storing the message payload.'

Signed-off-by: Andras Dobrosi dobrosi@gmail.com

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 7, 2025
Signed-off-by: Andras Dobrosi <dobrosi@gmail.com>
Signed-off-by: Andras Dobrosi <dobrosi@gmail.com>
@bclozel bclozel self-assigned this Feb 7, 2025
@bclozel bclozel added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 7, 2025
@bclozel bclozel added this to the 6.2.x milestone Feb 7, 2025
@bclozel bclozel changed the title File name is null bug fixed ContentDisposition should match attributes in a case-insensitive fashion Feb 7, 2025
@bclozel
Copy link
Member

bclozel commented Feb 7, 2025

@dobrosi don't worry about the build failure, I'll take it from here. Thanks for your first contribution, I'll get back to you if I have any feedback.

@bclozel bclozel modified the milestones: 6.2.x, 6.1.17 Feb 10, 2025
@bclozel bclozel closed this in 2b4c7d0 Feb 10, 2025
@bclozel bclozel modified the milestones: 6.1.17, 6.2.3 Feb 10, 2025
@bclozel
Copy link
Member

bclozel commented Feb 10, 2025

Thanks for your first contribution @dobrosi! This is now merged with 2b4c7d0 and will be released later this week.

@dobrosi
Copy link
Contributor Author

dobrosi commented Feb 12, 2025

Thank you for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants