Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Partitioned cookie support in reactive HTTP clients #34521

Closed
wants to merge 2 commits into from

Conversation

dark2momo
Copy link
Contributor

While using org.springframework.cloud.gateway.test.BaseWebClientTests#testClient to check cookies, I found that the "partitioned" attribute was false, whereas the actual response showed it as true.
This commit aims to fix the "partitioned" attribute in DefaultCookie from ReactorClientHttpResponse.getCookies()

As this is my first contribution, I would appreciate any feedback.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 28, 2025
@bclozel bclozel self-assigned this Feb 28, 2025
@bclozel bclozel added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Feb 28, 2025
@bclozel
Copy link
Member

bclozel commented Feb 28, 2025

Thanks for your contribution!

We cannot merge this change right now, as we need you to first sign the Developer Certificate of Origin (DCO).
If your contribution matches the requirements, you can update your PR like so:

$ git amend -s
$ git push --force

For more details on this, check out our dedicated blog post: Hello DCO, Goodbye CLA

…Response.getCookies

Signed-off-by: Rhett CfZhuang <dark.momo985@gmail.com>
@dark2momo
Copy link
Contributor Author

Thanks for your contribution!

We cannot merge this change right now, as we need you to first sign the Developer Certificate of Origin (DCO). If your contribution matches the requirements, you can update your PR like so:

$ git amend -s
$ git push --force

For more details on this, check out our dedicated blog post: Hello DCO, Goodbye CLA

Hi @belozel,

Thank you for your guidance! I have now signed the Developer Certificate of Origin (DCO). Additionally, I will complete the unit tests for ReactorClientHttpResponseTest.java to ensure full coverage later. Please let me know if there’s anything else needed from my side.

@bclozel
Copy link
Member

bclozel commented Feb 28, 2025

Thanks @dark2momo
No need to add more tests, let me have a look first. I'll do that first thing on Monday.

@bclozel bclozel changed the title Fixed "partitioned" attribute from DefaultCookie of ReactorClientHttpResponse.getCookies Missing Partitioned cookie support in reactive HTTP clients Mar 3, 2025
@bclozel bclozel added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 3, 2025
@bclozel bclozel closed this in 5faf2ed Mar 3, 2025
@bclozel bclozel added this to the 6.2.4 milestone Mar 3, 2025
@bclozel
Copy link
Member

bclozel commented Mar 3, 2025

Thanks for your contribution @dark2momo , this is now merged. I updated your commit to use the already existing connector integration tests and to apply similar support for the HttpComponents client.

@dark2momo
Copy link
Contributor Author

Excited to see my first contribution merged~@bclozel Thanks for your work polishing the commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants