Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormHttpMessageConverter should throw HttpMessageNotReadableException when the http form data is invalid #34594

Closed
wants to merge 1 commit into from

Conversation

Helmsdown
Copy link

@Helmsdown Helmsdown commented Mar 13, 2025

HttpMessageNotReadableException is a more specific exception that will allow users to better target and react to invalid request payloads.

@sdeleuze here is the change per our conversation per #34584

… instead of IllegalArgumentException when the http form data is invalid

HttpMessageNotReadableException is a more specific exception that will allow users to better target and react to invalid request payloads

Signed-off-by: Russell Bolles <rbolles@netflix.com>
@sdeleuze sdeleuze self-assigned this Mar 17, 2025
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 17, 2025
@sdeleuze sdeleuze added this to the 6.2.5 milestone Mar 17, 2025
@sdeleuze sdeleuze changed the title FormHttpMessageConverter should throw HttpMessageNotReadableException instead of IllegalArgumentException when the http form data is invalid FormHttpMessageConverter should throw HttpMessageNotReadableException when the http form data is invalid Mar 17, 2025
sdeleuze pushed a commit to sdeleuze/spring-framework that referenced this pull request Mar 17, 2025
FormHttpMessageConverter could throw a more specific
HttpMessageNotReadableException instead of an IllegalArgumentException
when the http form data is invalid.

See spring-projectsgh-34594
Signed-off-by: Russell Bolles <rbolles@netflix.com>
@sdeleuze sdeleuze closed this in 46859d6 Mar 17, 2025
@sdeleuze
Copy link
Contributor

Polished and merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants