Skip to content

Correctly expand query param with same name from URI variables array #34783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

whlit
Copy link

@whlit whlit commented Apr 20, 2025

Fixes #34781

For repeated fields, the original method is to overwrite them instead of adding them to the original array.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 20, 2025
Signed-off-by: whl <whlit.cola@gmail.com>
@whlit whlit force-pushed the fix_format_duplicate_url_fields branch from ba95cb0 to 0ae1fd2 Compare April 20, 2025 06:12
@bclozel
Copy link
Member

bclozel commented Apr 20, 2025

@whlit could you add a unit test for that?

@whlit
Copy link
Author

whlit commented Apr 20, 2025

@whlit could you add a unit test for that?

OK, I'll add it

Signed-off-by: whl <whlit.cola@gmail.com>
@rstoyanchev rstoyanchev self-assigned this Apr 22, 2025
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 22, 2025
@rstoyanchev rstoyanchev added this to the 6.2.7 milestone Apr 22, 2025
@rstoyanchev rstoyanchev changed the title Fix uri format with duplicate fields. Correctly expand query param with same name from URI variables array Apr 22, 2025
@christophejan
Copy link
Contributor

Thank you very much @whlit @bclozel @rstoyanchev
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
5 participants