Skip to content

RestTestClient.mutate() should not have side effects #35698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RestTestClient.mutate() should not have side effects #35698

wants to merge 1 commit into from

Conversation

@UpStreamThomas
Copy link

Before this change, DefaultRestTestClient.mutate() was reusing the underlying builder all calls.

Building a new builder for each call clones the RestTestClientBuilder, protecting from side effects.

@UpStreamThomas UpStreamThomas force-pushed the fix-rest-test-client-mutate-side-effect branch from 7916536 to 3df1c62 Compare October 28, 2025 11:33
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 28, 2025
@trecloux @UpStreamThomas
fix: RestTestClient.mutate() should not have side effects
5b30f1d 
Before this change, DefaultRestTestClient.mutate() was reusing the
underlying builder all calls.
Building a new builder for each call clones the RestTestClientBuilder,
protecting from side effects.

Signed-off-by: Thomas Recloux <trecloux@purse.eu>
@UpStreamThomas UpStreamThomas force-pushed the fix-rest-test-client-mutate-side-effect branch from 3df1c62 to 5b30f1d Compare October 29, 2025 08:52
RemiVangrevelynghe
RemiVangrevelynghe approved these changes Oct 31, 2025
View reviewed changes
Copy link

@RemiVangrevelynghe RemiVangrevelynghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@rstoyanchev rstoyanchev self-assigned this Oct 31, 2025
@rstoyanchev
Copy link
Contributor

Thanks for the pull request .This is done in .build() currently, but should be done in .mutate() instead.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 31, 2025
@rstoyanchev rstoyanchev added this to the 7.0.0 milestone Oct 31, 2025
@rstoyanchev rstoyanchev changed the title fix: RestTestClient.mutate() should not have side effects RestTestClient.mutate() should not have side effects Oct 31, 2025
@UpStreamThomas
Copy link
Author

Thanks for the pull request .This is done in .build() currently, but should be done in .mutate() instead.

I did not notice that that builder was cloned in the build() method, do you want me to remove it ?

@rstoyanchev
Copy link
Contributor

Yes, it should be removed from .build(), effectively moved to .mutate().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RemiVangrevelynghe RemiVangrevelynghe RemiVangrevelynghe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rstoyanchev rstoyanchev

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@UpStreamThomas @rstoyanchev @RemiVangrevelynghe @spring-projects-issues @trecloux