Fix circular placeholder prevention #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set of resolved placeholder references is used for circular placeholder prevention. For complex property definitions this mechanism would put property values with unresolved inner placeholder references in the set, but would try to remove property values with placeholders resolved, leaving set in invalid state and mechanism broken. This fix makes sure value that is put in set is same one that is removed from it, and by this avoid false positives in reporting circular placeholder. Issue: SPR-5369
cbeams
added a commit
that referenced
this pull request
May 17, 2012
* SPR-5369: Fix circular placeholder prevention
|
Thanks, Stevo! Committed, after changing Apache license date ranges and touching up the commit comment for minor grammar issues. |
GreenRecycleBin
added a commit
to GreenRecycleBin/spring-framework
that referenced
this pull request
Aug 9, 2019
"
{@code}
{@code text }
Equivalent to <code>{@literal text }</code>.
Displays text in code font without interpreting the text as HTML markup or nested Javadoc tags.
"
https://docs.oracle.com/en/java/javase/12/docs/specs/doc-comment-spec.html
This is why {@code &spring-projects#42;&spring-projects#47;&spring-projects#42;} isn't rendered as <code>*/*</code> as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of resolved placeholder references is used for circular placeholder
prevention. For complex property definitions this mechanism would put
property values with unresolved inner placeholder references in the
set, but would try to remove property values with placeholders
resolved, leaving set in invalid state and mechanism broken.
This fix makes sure value that is put in set is same one that is
removed from it, and by this avoid false positives in reporting
circular placeholder.
Issue: SPR-5369
I have signed and agree to the terms in the SpringSource Individual Contributor License Agreement.