Improve documentation of matrix variables. #447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, it was not clear how to enable the support of matrix variables in the mvc namespace. As the feature is disabled by default, added something to highlight the part that explains how to configure it Issue: SPR-11331
| @@ -28776,10 +28776,37 @@ All matrix variables may be obtained in a Map: | |||
| } | |||
| ---- | |||
|
|
|||
| Note that to enable the use of matrix variables, you must set the | |||
| `removeSemicolonContent` property of `RequestMappingHandlerMapping` to `false`. By | |||
| default it is set to `true`. | |||
There was a problem hiding this comment.
The above text should not be deleted IMO. It covers those who use neither the MVC namespace nor the MVC Java config. It makes sense to keep it as information on where the configuration setting lives. Then the tip explains how it relates to MVC namespace and Java config users.
There was a problem hiding this comment.
This is redundant information to me (I didn't delete it, I moved it). Would be this useful when not using Java config? If so, that's what I am missing.
Prior to this commit, it was not clear how to enable the support of matrix variables in the mvc namespace. As the feature is disabled by default, added something to highlight the part that explains how to configure it Issue: SPR-11331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, it was not clear how to enable the support of matrix
variables in the mvc namespace. As the feature is disabled by default, added
something to highlight the part that explains how to configure it.
Issue: SPR-11331