Fix method signature mismatch in Quartz #452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quartz 2.2 provides methods to register JobListener and TriggerListener that the previous 2.0.x generations do not define. However, a method taking an extra list of KeyMatcher instances exists since 2.0.0 This commit uses this method instead of the one that was introduced as from 2.2.0 to ensure compatibility with previous 2.0.x releases Issue: SPR-11362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quartz 2.2 provides methods to register
JobListenerandTriggerListenerthat the previous 2.0.x generations do not define. However, a method taking an extra list ofKeyMatcherinstances exists since 2.0.0This commit uses this method instead of the one that was introduced as from 2.2.0 to ensure compatibility with previous 2.0.x releases.
It is hard to test such a change in the current infrastructure so a separate project was used to validate that the scheduler is properly created when those listeners are present. This has been tested against
1.8.6,2.0.0,2.1.0and2.2.0.Issue: SPR-11362