SPR-11875: Performance regression for custom autowireBean calls with many properties #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert commit e1d11ec and use ConcurrentReferenceHashMap to fix SPR-8956 memory leak instead. Issue: SPR-11875, SPR-8956
|
A series of commits has been made that addresses the issue that pull requests would fix, so I think it should be closed. @trask do you still have the Groovy bean performance problem you mentioned at https://jira.spring.io/browse/SPR-11875?focusedCommentId=105103&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-105103 ? |
|
ping @jhoeller |
spring-projects-issues
added
the
status: waiting-for-triage
|
@trask Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
rstoyanchev
added
the
in: core
|
Closing as the related issue has been fixed. |
snicoll
added
status: superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see SPR-11875.
This commit reverts e1d11ec and uses ConcurrentReferenceHashMap to fix SPR-8956 memory leak instead.
Autowire benchmark https://github.com/trask/spring-autowire-benchmark is back in line with Spring 3.1.4 after this.
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.