DelegatingFilterProxy looks at "registered" WebApplicationContexts #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
This method should be named getRegisteredWebApplicationContexts (i.e. plural).
Member
Author
There was a problem hiding this comment.
Good catch! This is fixed now.
Previously when users registered an additional Filter in the DispatcherServlet the DelegatingFilterProxy would not find it unless the context attribute was set. The value for which was difficult to remember and added quite a bit of additional "if" statements to setting up Spring Security successfully. This change allows registering additional known WebApplicationContext instances. The DispatcherServlet uses this mechanism to register its context. With that change DelegatingFilterProxy searches for the first registered WebApplicationContext that contains the bean name. This change also sets up the ability for Spring Security to lookup Beans defined in the child context within the Tag libs. Issue: SPR-13191
Member
|
Very interesting proposal! |
Previously using jdbcTemplate.queryForObject(sql, int.class) produced a TypeMismatchDataAccessException stating it could not convert an Integer to an int. This update allows conversion to the respective primitives instead of just the wrapper Objects. Issue: SPR-13220
Member
Author
|
Closing since this was resolved in 1fcd465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when users registered an additional Filter in the
DispatcherServlet the DelegatingFilterProxy would not find it unless
the context attribute was set. The value for which was difficult to
remember and added quite a bit of additional "if" statements to setting
up Spring Security successfully.
This change allows registering additional known WebApplicationContext
instances. The DispatcherServlet uses this mechanism to register its
context. With that change DelegatingFilterProxy searches for the first
registered WebApplicationContext that contains the bean name.
This change also sets up the ability for Spring Security to lookup
Beans defined in the child context within the Tag libs.
Issue: SPR-13191