Skip to content

Add client-side interception on GraphQlClient #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Mar 16, 2022 · 1 comment
Closed

Add client-side interception on GraphQlClient #332

rstoyanchev opened this issue Mar 16, 2022 · 1 comment
Assignees
@rstoyanchev
Labels
type: enhancement A general enhancement
Milestone
1.0.0-M6

Comments

@rstoyanchev
Copy link
Contributor

Similar to the WebInterceptor chain on the server side but for use with GraphQlClient. This would also include a WebSocket specific interceptor for WebSocket specific needs (connection_init and connection_ack payload, disconnects, etc).
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Mar 16, 2022
@rstoyanchev rstoyanchev added this to the 1.0.0-M6 milestone Mar 16, 2022
@rstoyanchev rstoyanchev self-assigned this Mar 16, 2022
@rstoyanchev rstoyanchev mentioned this issue Mar 16, 2022
Closed
rstoyanchev added a commit that referenced this issue Mar 21, 2022
@rstoyanchev
Extract GraphQlRequest interface
be05b03 
See gh-332
rstoyanchev added a commit that referenced this issue Mar 21, 2022
@rstoyanchev
Extract ExecutionGraphQl[Request|Response] interfaces
182e9e6 
Rename the implementation classes Request[Input|Output] accordingly to
match the interfaces, and move them into the support package.

Create AbstractGraphQlResponse in the support package that
pre-implements response field access.

This leaves mainly contracts in the top-level package.

See gh-332
rstoyanchev added a commit that referenced this issue Mar 21, 2022
@rstoyanchev
Rename Web[Input|Output] to WebGraphQl[Request|Response]
67711f7 
See gh-332
rstoyanchev added a commit that referenced this issue Mar 21, 2022
@rstoyanchev
Shorten GraphQlResponse[Field|Error] and rename GraphQlService
91e7f28 
Rename GraphQlService to ExecutionGraphQlService following the renaming
of the request and response to ExecutionGraphQl[Request|Response].

See gh-332
rstoyanchev added a commit that referenced this issue Mar 21, 2022
@rstoyanchev
Correct names of AbstractDirectTransport and subclasses
bb4ebf6 
See gh-332
@rstoyanchev
Copy link
Contributor Author

Also commits f54ee52 and bb62808 incorrectly linked to different issue.

bclozel added a commit to spring-projects/spring-boot that referenced this issue Mar 21, 2022
@bclozel
Adapt to latest Spring GraphQL changes
bae62c3 
This commit adapts to the latest Spring GraphQL changes, renaming
`GraphQlService` to `ExecutionGraphQlService` as well as the
`WebInterceptor` contract to `WebGraphQlHandlerInterceptor`.

See spring-projects/spring-graphql#332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.0-M6
Development

No branches or pull requests
1 participant
@rstoyanchev