Skip to content

Add spring-webflux to the dependecies of spring-graphql-test #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hantsy opened this issue Jun 18, 2021 · 1 comment
Closed

Add spring-webflux to the dependecies of spring-graphql-test #62

hantsy opened this issue Jun 18, 2021 · 1 comment
Assignees
@bclozel
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@hantsy
Copy link
Contributor

hantsy commented Jun 18, 2021 •
edited
Loading

When creating a WebMVC project and writing some tests with GraphQlTester, and I found the GraphQlTester is dependent on WebClient or WebTestClient which is part of spring-webflux.

So I think it is better to add spring-webflux as dependency of spring-graphql-test by default.
@bclozel bclozel self-assigned this Jun 18, 2021
@bclozel bclozel added the type: bug A general bug label Jun 18, 2021
@bclozel bclozel added this to the 1.0 M1 milestone Jun 18, 2021
@rstoyanchev
Copy link
Contributor

This is true currently, but ideally GraphQlTester should be flexible for use over any transport. I've created #65.

@rstoyanchev rstoyanchev added status: declined A suggestion or change that we don't feel we should currently apply and removed type: bug A general bug labels Jun 23, 2021
@rstoyanchev rstoyanchev removed this from the 1.0 M1 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @rstoyanchev @hantsy