Skip to content

GraphqlTester should not have web dependencies #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rstoyanchev opened this issue Jun 23, 2021 · 2 comments
Closed

GraphqlTester should not have web dependencies #65

rstoyanchev opened this issue Jun 23, 2021 · 2 comments
Assignees
Labels
in: test Issues related to the test module in: web Issues related to web handling type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jun 23, 2021

There is nothing in GraphQlTester that is web specific, apart from the factory methods accepting WebTestClient and WebGraphqlHandler, but that'll change as we add web specific inputs for #64.

We can create a WebGraphQlTester that extends GraphQlTester, allows additional, web-specific inputs, and exposes web-specific factory methods, while GraphQlTester remains neutral to the underlying transport it is used with. In the future we may have other such extensions, for example for testing GraphQL requests over RSocket.

@rstoyanchev rstoyanchev added type: enhancement A general enhancement in: web Issues related to web handling in: test Issues related to the test module labels Jun 23, 2021
@rstoyanchev rstoyanchev added this to the 1.0 M1 milestone Jun 23, 2021
@rstoyanchev rstoyanchev self-assigned this Jun 23, 2021
@hantsy
Copy link
Contributor

hantsy commented Jun 23, 2021

So there may be an additional GraphQL over RSocket and GraphQL over WebSocket implementations as alternatives of the existing GraphQL over HTTP in Spring GraphQL?

@rstoyanchev
Copy link
Contributor Author

Yes exactly. Even what we have at the moment is flexible to execute with or without an HTTP client, but this would more formally separate Web (HTTP, WebSocket) from other transports like RSocket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues related to the test module in: web Issues related to web handling type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants