Support for BatchHandlerMethodArgumentResolver #298
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR
Replace hard code in
BatchLoaderHandlerMethod
withBatchHandlerMethodArgumentResolver
, and support customBatchHandlerMethodArgumentResolver
.1、The reason spring-graphql should support
BatchHandlerMethodArgumentResolver
In #232 , I suggested that
@BatchMapping
should support@Argument
, because user will define arguments on field, no matter whether the field is fetched by DataLoader way or 'n+1' way.Furthermore, user will always want to get information about field, such as field definition or directives.
Hence, I think
BatchLoaderHandlerMethod
should support argumentResolveStrategies which resolving argument values into various method parameters.2、The way spring-graphql support
BatchHandlerMethodArgumentResolver
BatchMappingDataFetcher
could pass DataFetchingEnvironment to DataLoader by invokingdataLoader.load(env.getSource(), env)
(the following code), andBatchLoaderHandlerMethod
and argument resolve strategies will get all the information about the fetched field.Brief change log
TODO: for validation and doc.