Add fine-grained starter modules #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
force-pushed
the
GH-90-separate-starters
branch
from
f22f6ad to
d17b48e
Compare
onobc
force-pushed
the
GH-90-separate-starters
branch
from
21e5dc2 to
042c21a
Compare
onobc
commented
Feb 4, 2025
onobc
commented
Feb 4, 2025
onobc
force-pushed
the
GH-90-separate-starters
branch
2 times, most recently
from
5956abd to
2b43eb2
Compare
onobc
commented
Feb 7, 2025
|
This looks ready. Conflicts in the pesky config props doc. Does it make sense to turn the generation of that file into a manual step, so it doesn't pollute all our commits with bogus changes? |
Signed-off-by: Chris Bono <chris.bono@gmail.com>
Currently the spring-grpc-core imposes an opinion on Netty. The core module should not have an opinion, but rather the starter enforces the opinion. Also, makes spring-grpc-core optional in the autconfigure module as the autoconfigure will eventually be moved into Spring Boot and at that time everything is optional. Signed-off-by: Chris Bono <chris.bono@gmail.com>
This adds a starter module that includes the Spring gRPC core module and the grpc-stub dependency. Also, makes the `grpc-stub` dependency optional in Spring gRPC core module. Signed-off-by: Chris Bono <chris.bono@gmail.com>
This adds a starter module that includes the Spring gRPC server starter and the required dependencies ((`spring-boot-starter-web` and `jakarta-grpc-servlet`) to use the servlet container as a gRPC server. Signed-off-by: Chris Bono <chris.bono@gmail.com>
Signed-off-by: Chris Bono <chris.bono@gmail.com>
The build.gradle previous use of `replacedBy` is consistent w/ what is already in the ref guide. Signed-off-by: Chris Bono <chris.bono@gmail.com>
This adds a new starter module (`spring-grpc-server-spring-boot-starter`) for gRPC Netty server and updates the current coarse-grained starter (`spring-grpc-spring-boot-starter`) to include the newly added server and client starter modules. Signed-off-by: Chris Bono <chris.bono@gmail.com>
Signed-off-by: Chris Bono <chris.bono@gmail.com>
Signed-off-by: Chris Bono <chris.bono@gmail.com>
Signed-off-by: Chris Bono <chris.bono@gmail.com>
onobc
force-pushed
the
GH-90-separate-starters
branch
from
fc2e734 to
ab72aa3
Compare
I captured this here #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
grpc-nettyoptional and leaves the opinion to the starter