Change signature of ReactiveRepresentationModelAssembler

[toedter]

The current signature of ReactiveRepresentationModelAssembler is

public interface ReactiveRepresentationModelAssembler<T, D extends RepresentationModel<D>>

The non-reactive RepresentationModelAssembler has the signature:

public interface RepresentationModelAssembler<T, D extends RepresentationModel<?>>

which makes it possible to work together with custom media type implementations (JSON:API, Siren, ...) that provide public RepresentationModel<?> API rather than exposing their internal RepresentationModel implementations as public API.

Would it make sense to change the signature of ReactiveRepresentationModelAssembler to

public interface ReactiveRepresentationModelAssembler<T, D extends RepresentationModel<?>>

?

This would have the following 2 advantages:

1. Custom media type implementations could be used out of the box
2. API consistency between reactive and non-reactive RepresentationModelAssemblers

[odrotbohm]

Thanks for filing this, Kai. This looks like an oversight to me. I'll check what the compatibility implications are of this, but I am afraid we at least cause binary incompatibility here. I guess the first version we can ship this in is 2.0 then, as there's no 1.6 release planned anymore.

[toedter]

Thx for the quick response, Oli!

[odrotbohm]

This should be in place for the 2.0 snapshots. Please let me know if we should investigate how a merge into 1.5.x would affect compatibility.

[toedter]

For me it would be fine to have it only in 2.x.

On the other side, I would expect this to be a backward-compatible change, that could potentially also applied to 1.5.x. But I am NOT an expert in this, and it is probably not worth spending much time investigating :)