-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Flaky tests #1726
Open
HildoYe
wants to merge
16
commits into
spring-projects:main
Choose a base branch
from
HildoYe:linkrelation-flaky-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes Flaky tests #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@HildoYe Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@HildoYe Thank you for signing the Contributor License Agreement! |
odrotbohm
force-pushed
the
main
branch
3 times, most recently
from
November 16, 2022 17:53
2e02d7a
to
856b6b9
Compare
odrotbohm
force-pushed
the
main
branch
4 times, most recently
from
November 16, 2023 10:46
5828e78
to
e643c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a several flaky tests and this PR fixes those. The problems are entirely ordering issues, and the proposed solutions is mainly to use annotations
@JsonPropertyOrder
.The flakiness can be test with
mvn -pl . edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=TESTNAME
Tests fixed:
config.CustomHypermediaWebFluxTest#getUsingCustomMediaType
config.CustomHypermediaWebMvcTest#getUsingCustomMediaType
EntityModelIntegrationTest#inlinesContent
IanaLinkRelationUnitTest#testAllIanaLinkRelationsHaveStringConstant
Jackson2LinkIntegrationTest#writesLinkCorrectly
Jackson2ResourceSupportIntegrationTest#doesNotRenderId
Jackson2ResourceIntegrationTest#inlinesContent
Jackson2PagedResourcesIntegrationTest#serializesPagedResourcesCorrectly
mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderComplexStructure
mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderSimplePojos
mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#rendersMultipleLinkAsArray
mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#serializesPagedResource
mediatype.hal.forms.HalFormsObjectMapperCustomizerTest#objectMapperCustomizerShouldBeApplied
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKey
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKey
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersCuriesCorrectly
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleResourceResourcesAsEmbedded
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersRepresentationModelWithTemplates
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleCuries
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersResource
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesAnnotatedResourceResourcesAsEmbedded
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesMultipleAnnotatedResourceResourcesAsEmbedded
mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesPagedResource
mediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKey
mediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKey
mediatype.hal.Jackson2HalIntegrationTest#rendersAllExtraRFC8288Attributes
mediatype.hal.Jackson2HalIntegrationTest#rendersMultipleCuries
mediatype.hal.Jackson2HalIntegrationTest#rendersMultipleResourceResourcesAsEmbedded
mediatype.hal.Jackson2HalIntegrationTest#serializesAnnotatedResourceResourcesAsEmbedded
mediatype.hal.Jackson2HalIntegrationTest#serializesPagedResource
mediatype.hal.HalModelBuilderUnitTest#previewForLinkRelationsUsingHalModelBuilder
mediatype.hal.HalModelBuilderUnitTest#progressivelyAddingContentUsingHalModelBuilder
mediatype.hal.HalModelBuilderUnitTest#renderDifferentlyTypedEntities
mediatype.hal.HalModelBuilderUnitTest#renderExplicitAndImplicitLinkRelations
mediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingDefaultModelBuilder
mediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingHalModelBuilder
mediatype.hal.HalModelBuilderUnitTest#embeddedSpecUsingHalModelBuilder
mediatype.hal.HalObjectMapperCustomizerTest#objectMapperCustomizerShouldBeApplied
mediatype.problem.JacksonSerializationTest#extensionSerialize
RepresentationModelIntegrationTest#doesNotRenderId