Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Flaky tests #1726

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

HildoYe
Copy link

@HildoYe HildoYe commented Nov 29, 2021

There a several flaky tests and this PR fixes those. The problems are entirely ordering issues, and the proposed solutions is mainly to use annotations @JsonPropertyOrder.

The flakiness can be test with mvn -pl . edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=TESTNAME

Tests fixed:

  • config.CustomHypermediaWebFluxTest#getUsingCustomMediaType
  • config.CustomHypermediaWebMvcTest#getUsingCustomMediaType
  • EntityModelIntegrationTest#inlinesContent
  • IanaLinkRelationUnitTest#testAllIanaLinkRelationsHaveStringConstant
  • Jackson2LinkIntegrationTest#writesLinkCorrectly
  • Jackson2ResourceSupportIntegrationTest#doesNotRenderId
  • Jackson2ResourceIntegrationTest#inlinesContent
  • Jackson2PagedResourcesIntegrationTest#serializesPagedResourcesCorrectly
  • mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderComplexStructure
  • mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderSimplePojos
  • mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#rendersMultipleLinkAsArray
  • mediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#serializesPagedResource
  • mediatype.hal.forms.HalFormsObjectMapperCustomizerTest#objectMapperCustomizerShouldBeApplied
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKey
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKey
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersCuriesCorrectly
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleResourceResourcesAsEmbedded
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersRepresentationModelWithTemplates
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleCuries
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersResource
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesAnnotatedResourceResourcesAsEmbedded
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesMultipleAnnotatedResourceResourcesAsEmbedded
  • mediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesPagedResource
  • mediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKey
  • mediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKey
  • mediatype.hal.Jackson2HalIntegrationTest#rendersAllExtraRFC8288Attributes
  • mediatype.hal.Jackson2HalIntegrationTest#rendersMultipleCuries
  • mediatype.hal.Jackson2HalIntegrationTest#rendersMultipleResourceResourcesAsEmbedded
  • mediatype.hal.Jackson2HalIntegrationTest#serializesAnnotatedResourceResourcesAsEmbedded
  • mediatype.hal.Jackson2HalIntegrationTest#serializesPagedResource
  • mediatype.hal.HalModelBuilderUnitTest#previewForLinkRelationsUsingHalModelBuilder
  • mediatype.hal.HalModelBuilderUnitTest#progressivelyAddingContentUsingHalModelBuilder
  • mediatype.hal.HalModelBuilderUnitTest#renderDifferentlyTypedEntities
  • mediatype.hal.HalModelBuilderUnitTest#renderExplicitAndImplicitLinkRelations
  • mediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingDefaultModelBuilder
  • mediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingHalModelBuilder
  • mediatype.hal.HalModelBuilderUnitTest#embeddedSpecUsingHalModelBuilder
  • mediatype.hal.HalObjectMapperCustomizerTest#objectMapperCustomizerShouldBeApplied
  • mediatype.problem.JacksonSerializationTest#extensionSerialize
  • RepresentationModelIntegrationTest#doesNotRenderId

@pivotal-cla
Copy link

@HildoYe Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@HildoYe Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants