Fixed Traverson double encoding issue #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
pushed a commit
that referenced
this pull request
Sep 3, 2015
We now avoid calling URI.toString() to early to prevent the need to re-parse it and thus accidentally cause a double-encoding. Original pull request: #382.
|
Polished and merged. Thanks! |
odrotbohm
changed the title
|
Awesome, great to have contributed. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@olivergierke @gregturn
Hi guys, here's the PR with squashed commits, rebased onto current master (hope that's correct - first time doing some of this stuff for me..).
It was a little more complicated in the end as my original change had broken another Traverson test case (
TraversonTest#returnsTemplatedLinkIfRequested). So there's now an additional private helper method in there to provide the option of traversing to a final, expandedURI(as required for the calls toRESTOperations#exchange(), or alternatively traverse to a templated StringHope that makes sense, let me know what you think.