Skip to content

GH-9996: Migrating remaining tests to Junit Jupiter and Deprecate Junit4 utilities #10087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

GH-9996: Migrating remaining tests to Junit Jupiter and Deprecate Junit4 utilities #10087

merged 2 commits into from
Jun 9, 2025

Conversation

mjd507
Copy link
Contributor

@mjd507 mjd507 commented Jun 9, 2025 •
edited by cppwfs
Loading

first commit: migrate remaining tests to Junit Jupiter
second one: deprecate Junit 4 utilities

fixes: #9996

mjd507 added 2 commits June 9, 2025 00:51
@mjd507
migrate remaining tests to Junit Jupiter
b8dcdc8 
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@mjd507
Deprecate JUnit 4 utilities
cd07e6b 
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
cppwfs
cppwfs requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@cppwfs cppwfs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

In this case let's leave these SingleRequestResponseScenarioTests and its parent as plural. While there is only a single test at present, it does not mean that ones can be added in the future.

@artembilan
Copy link
Member

In this case let's leave these SingleRequestResponseScenarioTests and its parent as plural.

I think the change in this PR on the matter is OK.
Those scenario classes are abstract and supposed to be used in the implementation.
That is a fully-blown test class has to have a Tests suffix to satisfy our code style.

Thanks

@artembilan artembilan merged commit d229cb4 into spring-projects:main Jun 9, 2025
3 checks passed
@mjd507 mjd507 deleted the junit-jupiter branch June 10, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppwfs cppwfs cppwfs requested changes

Assignees

@cppwfs cppwfs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate JUnit 4 utilities in the project
3 participants
@mjd507 @artembilan @cppwfs