INT-3376 Support Meta-Annotation Att. Override #1132
Conversation
| */ | ||
| public final class MessagingAnnotationUtils { | ||
|
|
||
| private MessagingAnnotationUtils() {} |
There was a problem hiding this comment.
According to new SF code style it should be abstract class.
However I'd prefer this variant, because abstract class we can extend and invoke new ExtendedUtils().
Shouldn't it be moved to org.springframework.integration.util package?
There was a problem hiding this comment.
The util package is for utilities used across the project; this is localized to annotations. But I don't mind either way.
There was a problem hiding this comment.
Good. Let it be. Anyway the SF AnnotationUtils in the annotation package.
Let's offer offer this style for *Utils classes and the 120 line length to the code style.
However this private ctor should be in the end of class.
|
LGTM |
|
Pushed; squashed due to major changes; full hierarchy is now supported. |
|
Actually, looks good. However maybe we should push to 4.1 till SF will do everything on the matter in the its 4.1. See Juergen's comment: https://jira.spring.io/browse/SPR-11709?focusedCommentId=102153&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-102153 |
|
Here is a polishing with several fixes, refactirngs and improvements: artembilan@fbfa514 |
JIRA: https://jira.spring.io/browse/INT-3376 Allow user annotations with Messaging Meta-Annotations override/supplement attributes set on the meta-Annotation. PR Comments and More - Do not create a bean definition for the annotation (interface) when `MessagingGateway` is used as a meta-Annotation. - For a `MessagingGateway` restore attributes overridden with empty values - Other PR comments. Fully support meta-Annotation hierarchy.
* Upgrade JRuby to 1.7.12 * Replace `AnnotationFinder` with moving its methods to `MessagingAnnotationUtils` * Refactor aggregator classes to use `MessagingAnnotationUtils` to determine the method for annotation * Fix `IntegrationComponentScanRegistrar` to skip annotation classes * Fix `MessagingGatewayRegistrar#replaceEmptyOverrides` * Improve `MessagingAnnotationPostProcessor` to use `ReflectionUtils.USER_DECLARED_METHODS` `MethodFilter` * Change the `MethodAnnotationPostProcessor` hierarchy to use just list of annotations to process attributes
|
Merging after rebase... |
|
Merged |
JIRA: https://jira.spring.io/browse/INT-3376
Allow user annotations with Messaging Meta-Annotations
override/supplement attributes set on the meta-Annotation.