GH-3827: Fix RemoteFile GET STREAM session leak #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3827 The `AbstractRemoteFileOutboundGateway.doGet()` for a `STREAM` option does not close the `session` in case of error. This may lead to some leaks or exhausted caches * Close `session` in the `catch()` of the `AbstractRemoteFileOutboundGateway.doGet()` * Adjust the `SftpServerOutboundTests` to configure a `CachingSessionFactory` for the `testStream()` to verify there is no leaks attempting to `GET STREAM` non-existing remote file twice **Cherry-pick to `5.5.x`**
|
...and cherry-picked as 19b4668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3827
The
AbstractRemoteFileOutboundGateway.doGet()for aSTREAMoptiondoes not close the
sessionin case of error.This may lead to some leaks or exhausted caches
sessionin thecatch()of theAbstractRemoteFileOutboundGateway.doGet()SftpServerOutboundTeststo configure aCachingSessionFactoryfor the
testStream()to verify there is no leaks attempting toGET STREAMnon-existing remote file twiceCherry-pick to
5.5.x