Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Blocking Retries: Consider Making it Easier to Route to Different DLTs by Exception Type #2800

Closed
garyrussell opened this issue Sep 7, 2023 · 3 comments
Closed

Non-Blocking Retries: Consider Making it Easier to Route to Different DLTs by Exception Type #2800

garyrussell opened this issue Sep 7, 2023 · 3 comments
Labels
type: enhancement
Milestone
3.2.0-M1

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Sep 7, 2023 •
edited
Loading

Currently requires some tricky code to capture the DLT properties; see https://stackoverflow.com/questions/77058404/custom-deadletterpublishingrecoverer-is-not-used-when-errors-occurs-during-valid/77060340#77060340

Typically deserialization exceptions could go to a different DLT than business exceptions.
@garyrussell garyrussell added this to the Backlog milestone Sep 7, 2023
@breader124
Copy link
Contributor

Hi, I'd like to start working on it if possible

@garyrussell
Copy link
Contributor Author

Sure, please go ahead.

breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 4, 2023
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
0322e7b 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 5, 2023
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
452fc47 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 8, 2023
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
e40235d 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 10, 2023
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
36bf3e2 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 10, 2023
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
95c5e5d 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 10, 2023
@breader124
spring-projectsGH-2800: wire configuration from annotation and traver…
c194f24 
…se causes

Closes spring-projects#2800
@breader124 breader124 mentioned this issue Dec 10, 2023
Merged
@breader124
Copy link
Contributor

I've just opened the PR with changes aimed to introduce the described feature: #2929

@sobychacko sobychacko modified the milestones: Backlog, 3.2.0-M1 Dec 13, 2023
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 13, 2023
@breader124
spring-projectsGH-2800: prepare custom DLT routing changes to be rele…
4f27772 
…ased in version 3.2.0

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Dec 15, 2023
@breader124
spring-projectsGH-2800: rename ExceptionBasedDestinationDlt to Except…
19cd845 
…ionBasedDltDestination
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
001d78b 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
50e67e8 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: wire configuration from annotation and traver…
a560793 
…se causes

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: prepare custom DLT routing changes to be rele…
1826676 
…ased in version 3.2.0

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: rename ExceptionBasedDestinationDlt to Except…
d21a564 
…ionBasedDltDestination
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: rebase changes on top of the most recent main
f76b2a6
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 19, 2024
@breader124
spring-projectsGH-2800: rebase changes on top of the most recent main
2c1240e
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: amendments after the code review
aa0b354
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
ba5a756 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
59faa7e 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: wire configuration from annotation and traver…
1baec9d 
…se causes

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: prepare custom DLT routing changes to be rele…
a1d6080 
…ased in version 3.2.0

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: rename ExceptionBasedDestinationDlt to Except…
0c55d8f 
…ionBasedDltDestination
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: rebase changes on top of the most recent main
09a2189
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: amendments after the code review
c094503
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: provide doc for the custom DLT routing feature
dadafa9 
Fixes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 20, 2024
@breader124
spring-projectsGH-2800: provide doc for the custom DLT routing feature
1777968 
Fixes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
8384d55 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
c19d918 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: wire configuration from annotation and traver…
cf1972e 
…se causes

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: prepare custom DLT routing changes to be rele…
575a1ad 
…ased in version 3.2.0

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: rename ExceptionBasedDestinationDlt to Except…
85c3841 
…ionBasedDltDestination
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: rebase changes on top of the most recent main
f0d76f6
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: amendments after the code review
797c010
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 25, 2024
@breader124
spring-projectsGH-2800: provide doc for the custom DLT routing feature
c5dd055 
Fixes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Jan 26, 2024
@breader124
spring-projectsGH-2800: code review amendments
474229f
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: create topics used for exception based DLT ro…
a37a85c 
…uting
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: route messages to specialized dlt based on ex…
0680fc6 
…ception type
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: wire configuration from annotation and traver…
9cad95c 
…se causes

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: prepare custom DLT routing changes to be rele…
bba2ebb 
…ased in version 3.2.0

Closes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: rename ExceptionBasedDestinationDlt to Except…
1a0a654 
…ionBasedDltDestination
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: rebase changes on top of the most recent main
420ec9f
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: amendments after the code review
bd76149
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: provide doc for the custom DLT routing feature
e46d481 
Fixes spring-projects#2800
breader124 added a commit to breader124/spring-kafka that referenced this issue Feb 1, 2024
@breader124
spring-projectsGH-2800: code review amendments
18220c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
3.2.0-M1
Development

No branches or pull requests
3 participants
@garyrussell @sobychacko @breader124