Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't recognize original exception when abortTransaction() failed #2981

Closed
chanhyeong opened this issue Jan 11, 2024 · 1 comment · Fixed by #2982
Closed

Can't recognize original exception when abortTransaction() failed #2981

chanhyeong opened this issue Jan 11, 2024 · 1 comment · Fixed by #2982
Assignees
@artembilan
Labels
backport-to-3.0.x (obsolete) status: backported type: bug
Milestone
3.1.2

Comments

@chanhyeong
Copy link
Contributor

chanhyeong commented Jan 11, 2024 •
edited
Loading

If an exception occur in the below code block producer.abortTransaction(), the original Exception e is discarded.

spring-kafka/spring-kafka/src/main/java/org/springframework/kafka/core/KafkaTemplate.java

Lines 660 to 663 in c683f31

catch (Exception e) {
producer.abortTransaction();
throw e;
}

I recently encountered this case, and I think the original was raised while processing upper line T result = callback.doInOperations(this);.

Is there any way to know about the original exception?
If not, it would be nice add logging of the exception or rethrowing composite exception.
@chanhyeong chanhyeong changed the title Can' recognize original exception when abortTransaction() failed Can't recognize original exception when abortTransaction() failed Jan 11, 2024
@artembilan
Copy link
Member

Confirming as a bug.
That supposed to use addSuppressed() for the original exception where we catch the one from abortTransaction().

@artembilan artembilan added this to the 3.1.2 milestone Jan 11, 2024
@artembilan artembilan self-assigned this Jan 11, 2024
artembilan added a commit to artembilan/spring-kafka that referenced this issue Jan 11, 2024
@artembilan
spring-projectsGH-2981: Suppress abortTransaction in KafkaTemplate
bd5b131 
Fixes: spring-projects#2981

When `producer.abortTransaction()` fails, the original exception is lost

* Catch an exception on `producer.abortTransaction()` and `ex.addSuppressed(abortException)`

**Cherry-pick to `3.0.x`**
@artembilan artembilan mentioned this issue Jan 11, 2024
Merged
artembilan added a commit to artembilan/spring-kafka that referenced this issue Jan 11, 2024
@artembilan
spring-projectsGH-2981: Suppress abortTransaction in KafkaTemplate
81047a2 
Fixes: spring-projects#2981

When `producer.abortTransaction()` fails, the original exception is lost

* Catch an exception on `producer.abortTransaction()` and `ex.addSuppressed(abortException)`

**Cherry-pick to `3.0.x`**
sobychacko pushed a commit that referenced this issue Jan 17, 2024
@artembilan
GH-2981: Suppress abortTransaction exception
550e6b1 
Fixes: #2981

When `producer.abortTransaction()` fails, the original exception is lost in `KafkaTemplate`.

* Catch an exception on `producer.abortTransaction()` and `ex.addSuppressed(abortException)`

**Cherry-pick to `3.0.x`**
sobychacko pushed a commit that referenced this issue Jan 17, 2024
@artembilan @sobychacko
GH-2981: Suppress abortTransaction exception
e36c22c 
Fixes: #2981

When `producer.abortTransaction()` fails, the original exception is lost in `KafkaTemplate`.

* Catch an exception on `producer.abortTransaction()` and `ex.addSuppressed(abortException)`

**Cherry-pick to `3.0.x`**
@spring-builds spring-builds mentioned this issue Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artembilan artembilan

Labels
backport-to-3.0.x (obsolete) status: backported type: bug
Projects
None yet
Milestone
3.1.2
Development

Successfully merging a pull request may close this issue.

GH-2981: Suppress abortTransaction in KafkaTemplate artembilan/spring-kafka
3 participants
@artembilan @spring-builds @chanhyeong