-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @Override of KafkaAdmin createAdmin() #3483
Comments
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson I think this is a reasonable request. In these cases, we usually recommend providing the correct bootstrap server config to |
@sobychacko thanks! I created #3484 and ran a few tests against it, seems like it has potential. |
That's great. We will review it and get back to you. |
Hi @sobychacko, I wanted to check in - have you been able to review this feature request? |
Sorry, we will get to it soon. |
@anders-swanson Sorry for the delay - the PR is now merged upstream and will be part of the upcoming |
Thanks! There might be a few more as I continue to experiment with Spring-Kafka and non-kafka-clients implementations of the Kafka interfaces. |
Expected Behavior
The Spring KafkaAdmin class has a package-private method "createAdmin" that returns the
org.apache.kafka.clients.admin.AdminClient
type:It'd be great if this method was protected, and returned the
org.apache.kafka.clients.admin.Admin
type. Additionally, the code in KafkaAdmin would need to be updated to use theAdmin
interface, instead of theKafkaAdmin
class.It's currently possible to do something similar the default producer/consumer factories, as they have methods like this:
Current Behavior
KafkaAdmin cannot be extended/overridden to use another type of class implementing the
org.apache.kafka.clients.admin.Admin
interface.Context
I'm using OKafka, which has implementations of the Kafka interfaces, e.g., the Admin interface, and I would like to use these implementations with Spring Kafka. Based on my understanding of the code, some modifications would need to be made as described - I'd also be interested in any workarounds, if they are available.
The text was updated successfully, but these errors were encountered: