Private Header Type for DeserializationExceptions #2770
Merged
+267
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a package-private header for deserialization exceptions. **cherry-pick to 2.9.x, 2.8.x**
artembilan
reviewed
Aug 8, 2023
| * deserialization. | ||
| * | ||
| * @author Gary Russell | ||
| * @since 2.9.11 |
There was a problem hiding this comment.
I will back-port here, but I won't back to 2.8.x until your confirmation.
There was a problem hiding this comment.
Yeah; let's just leave it at 2.9.x for now; I thought about 2.8.x because it is still in commercial support (2.7.x goes out soon) and it might make it easier if we are asked later to release it. But I don't think it will make much difference doing it now or then.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a package-private header for deserialization exceptions.
cherry-pick to 2.9.x