GH-2731: fix count and time ack mode #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Oct 25, 2023
| Duration.ofSeconds(42)); | ||
| verify(consumer).commitSync(Collections.singletonMap(topicPartition, new OffsetAndMetadata(7L)), | ||
| verify(consumer).commitSync(Collections.singletonMap(topicPartition, new OffsetAndMetadata(6L)), |
There was a problem hiding this comment.
Thanks for the contribution; in general it looks good but, in this case, the 7th record's offset will never be committed; I believe we need to accelerate the commit based on count if the next poll returns no records.
Restoring the
verify(consumer).commitSync(Collections.singletonMap(topicPartition, new OffsetAndMetadata(7L)),
Duration.ofSeconds(42));(after the test for offset 6) causes the test to fail.
We also need to adjust the comments on lines 3063, 3068.
count ack mode commit offset when next poll return no records
garyrussell
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2731