Skip to content

Conversation

@NathanQingyangXu
Copy link
Contributor

not 100% sure about some changes. There are roughly the following reasons of 'dead link's in javadocs:

  • previoulsy deprecated classes have been deleted (I provided the latest public javadoc link accessible; usually in v3.0.12)
  • outdated reference which should have been deleted when the referenced stuff had been removed (I removed them)
  • mystic references which are difficult to trace from even git history (I removed them simply; mainly in testing classes)
  • erroneous method signature (I fixed it by using correct signature)

There are a couple of links pointing to private methods in other classes. Not sure how to fix them so I didn't touch them or include them in this PR.

Again, feel free to change directly. Looking forward to corrections.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkstyle violation:

Error: [Task :spring-kafka:checkstyleMain] [Regexp] Line matches the illegal pattern 'Trailing whitespace'.

Consider to run `./gradlew check -x test` locally before pushing to PR.

Thanks

@NathanQingyangXu NathanQingyangXu force-pushed the correct-dead-link-in-javadocs branch from 3236cde to 47dd881 Compare November 14, 2023 23:28
@artembilan artembilan added this to the 3.1.0 milestone Nov 15, 2023
@artembilan artembilan merged commit a420ba0 into spring-projects:main Nov 15, 2023
@NathanQingyangXu NathanQingyangXu deleted the correct-dead-link-in-javadocs branch November 16, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants