GH-2978: Propagate number of partitions to KRaft broker #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#2978 If we don't create topics manually, that can be done automatically on the broker side according to its configuration. For that goal the `EmbeddedKafkaKraftBroker` is missing to populate `KafkaConfig.NumPartitionsProp(): "" + this.partitionsPerTopic` broker property from `@EmbeddedKafka` configuration * Propagate `partitionsPerTopic` option down to the embedded broker(s) in the `EmbeddedKafkaKraftBroker` * Some other simple refactoring in the `EmbeddedKafkaKraftBroker` * Verify the option propagated via new unit test in the `KafkaTestUtilsTests.topicAutomaticallyCreatedWithProperNumberOfPartitions()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2978
If we don't create topics manually, that can be done automatically on the broker side according to its configuration.
For that goal the
EmbeddedKafkaKraftBrokeris missing to populateKafkaConfig.NumPartitionsProp(): "" + this.partitionsPerTopicbroker property from@EmbeddedKafkaconfigurationpartitionsPerTopicoption down to the embedded broker(s) in theEmbeddedKafkaKraftBrokerEmbeddedKafkaKraftBrokerKafkaTestUtilsTests.topicAutomaticallyCreatedWithProperNumberOfPartitions()