Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Deserializer.deserialize(String, Headers, ByteBuffer) #3009

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Wzy19930507
Copy link
Contributor

adapt apache kafka feature, reduce CompletedFetch#parseRecord() memory copy, details see https://issues.apache.org/jira/browse/KAFKA-14944

…s, ByteBuffer data)`

adapt apache kafka feature, reduce `CompletedFetch#parseRecord()` memory copy, details see https://issues.apache.org/jira/browse/KAFKA-14944
@Wzy19930507 Wzy19930507 changed the title Implementation `Deserializer.deserialize(String, Headers, ByteBuffer) Implementation Deserializer.deserialize(String, Headers, ByteBuffer) Jan 31, 2024
@sobychacko
Copy link
Contributor

@Wzy19930507 one minor comment. I will do a detailed review today though.

@artembilan artembilan added this to the 3.2.0-M1 milestone Jan 31, 2024
@artembilan artembilan merged commit 3ee58fb into spring-projects:main Jan 31, 2024
3 checks passed
@artembilan
Copy link
Member

@Wzy19930507 ,

merged and thank you, but please, don't do not feature-related refactoring.
Better to do that work in separate PRs for easier and faster review.

@Wzy19930507 Wzy19930507 deleted the adapt_kafka_14944 branch February 1, 2024 01:40
@Wzy19930507
Copy link
Contributor Author

Thanks for the review and advice!
I will often remind myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants