GH-3467: Fix KafkaListenerAnnotationBeanPostProcessor for early BF access #3468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` for early BF access Fixes: spring-projects#3467 The `KafkaListenerAnnotationBeanPostProcessor.afterPropertiesSet()` get access to `BeanFactory` for other beans which causes a warning into logs like: ``` is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor ``` The rule of thumb is to not have any bean factory access from `BeanPostProcessor` initialization phase * Fix `KafkaListenerAnnotationBeanPostProcessor` to `buildEnhancer()` i lazy manner. Therefore remove an `afterPropertiesSet()` altogether **Auto-cherry-pick to `3.2.x` & `3.1.x`**
sobychacko
approved these changes
Aug 29, 2024
spring-builds
pushed a commit
that referenced
this pull request
Aug 29, 2024
…access (#3468) Fixes: #3467 #3467 The `KafkaListenerAnnotationBeanPostProcessor.afterPropertiesSet()` gets access to `BeanFactory` for other beans which causes a warning into logs like: ``` is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor ``` The rule of thumb is not to have any bean factory access from `BeanPostProcessor` initialization phase. * Fix `KafkaListenerAnnotationBeanPostProcessor` to `buildEnhancer()` in lazy manner. Therefore remove an `afterPropertiesSet()` altogether. (cherry picked from commit 4a135a1)
spring-builds
pushed a commit
that referenced
this pull request
Aug 29, 2024
…access (#3468) Fixes: #3467 #3467 The `KafkaListenerAnnotationBeanPostProcessor.afterPropertiesSet()` gets access to `BeanFactory` for other beans which causes a warning into logs like: ``` is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying). Is this bean getting eagerly injected into a currently created BeanPostProcessor ``` The rule of thumb is not to have any bean factory access from `BeanPostProcessor` initialization phase. * Fix `KafkaListenerAnnotationBeanPostProcessor` to `buildEnhancer()` in lazy manner. Therefore remove an `afterPropertiesSet()` altogether. (cherry picked from commit 4a135a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3467
The
KafkaListenerAnnotationBeanPostProcessor.afterPropertiesSet()get access toBeanFactoryfor other beans which causes a warning into logs like:The rule of thumb is to not have any bean factory access from
BeanPostProcessorinitialization phaseKafkaListenerAnnotationBeanPostProcessortobuildEnhancer()i lazy manner. Therefore remove anafterPropertiesSet()altogetherAuto-cherry-pick to
3.2.x&3.1.x